acelyc111 commented on code in PR #1248:
URL:
https://github.com/apache/incubator-pegasus/pull/1248#discussion_r1029481494
##########
src/utils/simple_logger.h:
##########
@@ -71,22 +72,22 @@ class simple_logger : public logging_provider
{
public:
simple_logger(const char *log_dir);
- virtual ~simple_logger(void);
+ ~simple_logger(void);
Review Comment:
I think it would be better to mark `override`.
https://github.com/isocpp/CppCoreGuidelines/issues/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
