acelyc111 commented on code in PR #1248:
URL: 
https://github.com/apache/incubator-pegasus/pull/1248#discussion_r1029508881


##########
src/utils/logging_provider.h:
##########
@@ -80,10 +74,16 @@ class logging_provider
 
     virtual void flush() = 0;
 
-private:
+    void deregister_commands() { _cmds.clear(); }
+
+protected:
+    logging_provider(const char *) {}

Review Comment:
   Removed it, we don't need it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to