acelyc111 commented on code in PR #1198:
URL:
https://github.com/apache/incubator-pegasus/pull/1198#discussion_r1036772425
##########
src/runtime/task/task.h:
##########
@@ -359,15 +359,18 @@ class timer_task : public task
void exec() override;
void enqueue() override;
+ void update_interval(int interval_ms);
+
protected:
void clear_non_trivial_on_task_end() override { _cb = nullptr; }
private:
- // ATTENTION: if _interval_milliseconds <= 0, then timer task will just be
executed once;
- // otherwise, timer task will be executed periodically(period =
_interval_milliseconds)
- int _interval_milliseconds;
+ // ATTENTION: if _interval_ms == 0, then timer task will just be executed
once;
+ // otherwise, timer task will be executed periodically(period =
_interval_ms)
+ int _interval_ms;
Review Comment:
Good suggestion, but I don't want to change it in this patch. There are many
callers have to update if changing it, these changes are not closer to this
patch topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
