acelyc111 commented on code in PR #1198:
URL:
https://github.com/apache/incubator-pegasus/pull/1198#discussion_r1036776353
##########
src/http/http_server.h:
##########
@@ -100,7 +100,31 @@ class http_service
virtual std::string path() const = 0;
- void register_handler(std::string path, http_callback cb, std::string
help);
+ void register_handler(std::string sub_path, http_callback cb, std::string
help);
Review Comment:
There may be very little performance improvement, and we have some methods
to avoid memory copy. C++ style would be more readable IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
