GehaFearless commented on code in PR #1272:
URL:
https://github.com/apache/incubator-pegasus/pull/1272#discussion_r1045576718
##########
src/meta/server_state.cpp:
##########
@@ -1259,6 +1259,102 @@ void server_state::drop_app(dsn::message_ex *msg)
}
}
+void server_state::rename_app_unlock(configuration_rename_app_rpc rpc)
+{
+ zauto_write_lock l(_lock);
Review Comment:
I see. I think merge two functions into one is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
