levy5307 commented on code in PR #1272:
URL:
https://github.com/apache/incubator-pegasus/pull/1272#discussion_r1048359310
##########
src/client/replication_ddl_client.cpp:
##########
@@ -53,6 +53,15 @@
namespace dsn {
namespace replication {
+#define VALIDATE_TABLE_NAME(app_name)
\
Review Comment:
```
inline bool validate_table_name(std::string app_name) {
...
}
```
I think it's better to implement it by inline func
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
