Samunroyu commented on code in PR #1706:
URL:
https://github.com/apache/incubator-pegasus/pull/1706#discussion_r1426147397
##########
src/replica/replica_stub.cpp:
##########
@@ -600,9 +646,30 @@ void replica_stub::initialize(const replication_options
&opts, bool clear /* = f
}
}
+ std::string encryption_key;
+ std::string iv;
+ std::string key_version;
+ std::string server_key;
+ // get and store eek from kms
+ if (key_provider && !utils::is_empty(FLAGS_hadoop_kms_url)) {
+ get_kms_key(_options.data_dirs[0], &encryption_key, &iv, &key_version);
Review Comment:
> Check _options.data_dirs is not empty at first, or it may crash without
any logs.
_options.data_dirs have been initialized and CHECK in the
replica_option.initialize(). May not CHECK twice here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
