Samunroyu commented on code in PR #1706:
URL:
https://github.com/apache/incubator-pegasus/pull/1706#discussion_r1426350755
##########
src/replica/replica_stub.cpp:
##########
@@ -573,6 +590,35 @@ void replica_stub::initialize(bool clear /* = false*/)
_access_controller = std::make_unique<dsn::security::access_controller>();
}
+dsn::error_s store_kms_key(std::string data_dir,
+ std::string encryption_key,
+ std::string iv,
+ std::string key_version)
+{
+ replica_kms_info kms_info(encryption_key, iv, key_version);
+ auto err = kms_info.store(data_dir);
+ if (dsn::ERR_OK == err) {
+ return dsn::error_s::ok();
+ } else {
+ return dsn::error_s::make(err, "Can't open replica_encrypted_key file
to write");
+ }
+}
+
+void get_kms_key(std::string data_dir,
+ std::string *encryption_key,
+ std::string *iv,
+ std::string *key_version)
+{
+ replica_kms_info kms_info;
+ auto err = kms_info.load(data_dir);
+ *encryption_key = kms_info.encryption_key;
+ *iv = kms_info.iv;
+ *key_version = kms_info.key_version;
+ if (dsn::ERR_OK != err) {
+ CHECK(err, "Can't open replica_encrypted_key file to read");
+ }
Review Comment:
> Use CHECK_OK.
The return err's type is erros_code. Cant use CHECK_OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
