Samunroyu commented on code in PR #1706:
URL:
https://github.com/apache/incubator-pegasus/pull/1706#discussion_r1433613530
##########
src/replica/replica_stub.cpp:
##########
@@ -291,13 +302,35 @@ DSN_DEFINE_int32(
10,
"if tcmalloc reserved but not-used memory exceed this percentage of
application allocated "
"memory, replica server will release the exceeding memory back to
operating system");
+DSN_DEFINE_string(pegasus.server,
+ encryption_cluster_key_name,
+ "pegasus",
+ "The cluster name of encrypted server which use to get
server key from kms.");
+
+DSN_DEFINE_string(
+ pegasus.server,
+ hadoop_kms_url,
+ "",
+ "Where the server key of file system can get from. "
+ "Url should be comma-separated list.Such as
'hostname1:1234/kms,hostname2:1234/kms'");
DSN_DECLARE_bool(duplication_enabled);
DSN_DECLARE_int32(fd_beacon_interval_seconds);
DSN_DECLARE_int32(fd_check_interval_seconds);
DSN_DECLARE_int32(fd_grace_seconds);
DSN_DECLARE_int32(fd_lease_seconds);
DSN_DECLARE_int32(gc_interval_ms);
+DSN_TAG_VARIABLE(encrypt_data_at_rest, FT_MUTABLE);
Review Comment:
> encrypt_data_at_rest should not be mutable.
According to src/utils/flags.h, the "FT_MUTABLE" meaning flag data is
mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
