GehaFearless commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1474134946
##########
src/failure_detector/failure_detector.cpp:
##########
@@ -302,28 +305,28 @@ void failure_detector::check_all_records()
}
}
-void failure_detector::add_allow_list(::dsn::rpc_address node)
+void failure_detector::add_allow_list(::dsn::host_port node)
{
zauto_lock l(_lock);
_allow_list.insert(node);
}
-bool failure_detector::remove_from_allow_list(::dsn::rpc_address node)
+bool failure_detector::remove_from_allow_list(::dsn::host_port node)
{
zauto_lock l(_lock);
return _allow_list.erase(node) > 0;
}
-void failure_detector::set_allow_list(const std::vector<std::string>
&replica_addrs)
+void failure_detector::set_allow_list(const std::vector<std::string>
&replica_hps)
{
CHECK(!_is_started, "FD is already started, the allow list should really
not be modified");
- std::vector<rpc_address> nodes;
- for (auto &addr : replica_addrs) {
- rpc_address node;
- if (!node.from_string_ipv4(addr.c_str())) {
+ std::vector<host_port> nodes;
+ for (auto &hp : replica_hps) {
+ host_port node;
+ if (!node.from_string(hp.c_str())) {
Review Comment:
del c_str()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
