acelyc111 commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1464343255
##########
src/runtime/rpc/asio_net_provider.cpp:
##########
@@ -356,7 +370,23 @@ void asio_udp_provider::do_receive()
return;
}
+ if (msg->header->from_address != remote_addr) {
Review Comment:
Why add this? It seems not related to FQDN.
##########
src/server/test/config.ini:
##########
@@ -493,15 +493,15 @@ profiler::cancelled = false
;profiler::timeout.qps = false
[meta_server]
-server_list = 0.0.0.0:34701
+server_list = 127.0.0.1:34701
Review Comment:
Why change this?
If the default behavior has changed to treat the server_list as hostnames,
and it doesn't work if they are IP addresses, how about introducing a new
config, e.g. `hostname_server_list`, to make it compatiable when user upgrade
Pegasus from old versions, so they don't needed to change configs when upgrade.
Other places are the same.
##########
src/runtime/rpc/rpc_engine.cpp:
##########
@@ -131,8 +133,10 @@ bool rpc_client_matcher::on_recv_reply(network *net,
uint64_t key, message_ex *r
// if this is pure client (no server port assigned), we can only do fake
forwarding,
// in this case, the server will return ERR_FORWARD_TO_OTHERS
if (err == ERR_FORWARD_TO_OTHERS) {
- rpc_address addr;
- ::dsn::unmarshall((dsn::message_ex *)reply, addr);
+ host_port hp;
Review Comment:
What happen if use rpc_address here and in line 857 (I guess they are in
pair, right?) ?
##########
src/runtime/rpc/rpc_message.h:
##########
@@ -137,6 +138,8 @@ class message_ex : public ref_counter, public
extensible_object<message_ex, 4>
rpc_session_ptr io_session; // send/recv session
rpc_address to_address; // always ipv4/v6 address, it is the to_node's
net address
rpc_address server_address; // used by requests, and may be of uri/group
address
+ host_port to_host_port; // fqdn from to_address, older versions use
fqdn as net
Review Comment:
What does "older versions use fqdn as net" mean?
##########
src/server/config.ini:
##########
@@ -94,6 +94,7 @@
io_service_worker_count = 4
; how many connections can be established from one ip address to a
server(both replica and meta), 0 means no threshold
conn_threshold_per_ip = 0
+ use_cache_resolve_hostname = true
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
