GehaFearless commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1474354798
##########
src/meta/test/meta_duplication_service_test.cpp:
##########
@@ -635,7 +641,7 @@ TEST_F(meta_duplication_service_test, duplication_sync)
ce.confirmed_decree = 5;
confirm_list[gpid(app->app_id, 1)].push_back(ce);
- duplication_sync_response resp = duplication_sync(node, confirm_list);
+ duplication_sync_response resp = duplication_sync(addr, node,
confirm_list);
Review Comment:
auto
##########
src/meta/test/meta_duplication_service_test.cpp:
##########
@@ -772,13 +778,13 @@ TEST_F(meta_duplication_service_test, fail_mode)
ASSERT_EQ(dup->status(), duplication_status::DS_PAUSE);
// ensure dup_sync will synchronize fail_mode
- std::vector<rpc_address> server_nodes = generate_node_list(3);
- rpc_address node = server_nodes[0];
+ auto node = generate_node_list(3)[0];
for (partition_configuration &pc : app->partitions) {
- pc.primary = server_nodes[0];
+ pc.primary = node.second;
+ pc.__set_hp_primary(node.first);
}
initialize_node_state();
- duplication_sync_response sync_resp = duplication_sync(node, {});
+ duplication_sync_response sync_resp = duplication_sync(node.second,
node.first, {});
Review Comment:
auto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
