acelyc111 commented on code in PR #1658:
URL:
https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1521183995
##########
src/meta/test/state_sync_test.cpp:
##########
@@ -381,10 +392,14 @@ void meta_service_test_app::construct_apps_test()
std::shared_ptr<meta_service> svc(new meta_service());
- std::vector<dsn::rpc_address> nodes;
+ std::vector<std::pair<dsn::host_port, dsn::rpc_address>> nodes;
std::string hint_message;
generate_node_list(nodes, 1, 1);
- svc->_state->construct_apps({resp}, nodes, hint_message);
+ std::vector<dsn::host_port> hps;
Review Comment:
TODO: optimize schema like "std::vector <dsn::host_port>"
##########
src/meta/test/state_sync_test.cpp:
##########
@@ -381,10 +392,14 @@ void meta_service_test_app::construct_apps_test()
std::shared_ptr<meta_service> svc(new meta_service());
- std::vector<dsn::rpc_address> nodes;
+ std::vector<std::pair<dsn::host_port, dsn::rpc_address>> nodes;
std::string hint_message;
generate_node_list(nodes, 1, 1);
- svc->_state->construct_apps({resp}, nodes, hint_message);
+ std::vector<dsn::host_port> hps;
Review Comment:
TODO: optimize schema like "std::vector\<dsn::host_port>"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
