acelyc111 commented on code in PR #1841:
URL:
https://github.com/apache/incubator-pegasus/pull/1841#discussion_r1477169449
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -235,7 +244,8 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
}
if (batch_count == muts.size() ||
- batch_bytes >= dsn::replication::FLAGS_duplicate_log_batch_bytes) {
+ batch_bytes >= dsn::replication::FLAGS_duplicate_log_batch_bytes ||
+ batch_bytes >= dsn::replication::FLAGS_dup_max_allowed_write_size)
{
Review Comment:
`batch_bytes` is still possible to be larger than `max_allowed_write_size`
on backup cluster even if `dup_max_allowed_write_size` equales to
`max_allowed_write_size`, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
