empiredan commented on code in PR #1841:
URL:
https://github.com/apache/incubator-pegasus/pull/1841#discussion_r1540747387
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -234,7 +242,8 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
batch_bytes += raw_message.length();
}
- if (batch_count == muts.size() || batch_bytes >=
FLAGS_duplicate_log_batch_bytes) {
+ if (batch_count == muts.size() || batch_bytes >=
FLAGS_duplicate_log_batch_bytes ||
+ batch_bytes >= dsn::replication::FLAGS_dup_max_allowed_write_size)
{
Review Comment:
Once `batch_bytes > dup_max_allowed_write_size` and `max_allowed_write_size
== dup_max_allowed_write_size`, would the message be rejected by
backup(follower) cluster ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pegasus.apache.org
For additional commands, e-mail: dev-h...@pegasus.apache.org
