empiredan commented on code in PR #2035:
URL:
https://github.com/apache/incubator-pegasus/pull/2035#discussion_r1618645928
##########
scripts/compile_thrift.py:
##########
@@ -220,13 +220,13 @@ def add_hook(name, path, func, args):
if __name__ == "__main__":
root_dir = os.getcwd()
- thrift_exe = root_dir + "/thirdparty/output/bin/thrift"
+ thrift_exe = os.environ['THIRDPARTY_ROOT'] + "/output/bin/thrift"
print("thrift_exe = " + thrift_exe)
print("root_dir = " + root_dir)
if not os.path.isfile(thrift_exe):
print("Error: can't find compiler %s\nPlease build thrift in
thirdparty/" % thrift_exe)
Review Comment:
`thirdparty/` should also be changed ?
##########
scripts/pack_server.sh:
##########
@@ -116,15 +116,15 @@ copy_file
${BUILD_LATEST_DIR}/output/lib/libdsn_replica_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_utils.so ${pack}/bin
if [ "$use_jemalloc" == "on" ]; then
- copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/bin
- copy_file ./thirdparty/output/lib/libprofiler.so.0 ${pack}/bin
+ copy_file ${THIRDPARTY_ROOT}/output/lib/libjemalloc.so.2 ${pack}/bin
Review Comment:
Before copy_file check if env `THIRDPARTY_ROOT` is an existing dir ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
