acelyc111 commented on code in PR #2035:
URL:
https://github.com/apache/incubator-pegasus/pull/2035#discussion_r1618802684
##########
scripts/pack_server.sh:
##########
@@ -116,15 +116,15 @@ copy_file
${BUILD_LATEST_DIR}/output/lib/libdsn_replica_server.so ${pack}/bin
copy_file ${BUILD_LATEST_DIR}/output/lib/libdsn_utils.so ${pack}/bin
if [ "$use_jemalloc" == "on" ]; then
- copy_file ./thirdparty/output/lib/libjemalloc.so.2 ${pack}/bin
- copy_file ./thirdparty/output/lib/libprofiler.so.0 ${pack}/bin
+ copy_file ${THIRDPARTY_ROOT}/output/lib/libjemalloc.so.2 ${pack}/bin
Review Comment:
scripts/pack_server.sh is typically called by ./run.sh, the
`THIRDPARTY_ROOT` has been set. And `copy_file` will exit if the source file is
not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
