acelyc111 commented on code in PR #2066:
URL:
https://github.com/apache/incubator-pegasus/pull/2066#discussion_r1689248868
##########
src/meta/duplication/meta_duplication_service.cpp:
##########
@@ -701,6 +702,10 @@ void meta_duplication_service::recover_from_meta_state()
_meta_svc->get_meta_storage()->get_children(
get_duplication_path(*app),
[this, app](bool node_exists, const std::vector<std::string>
&dup_id_list) {
+ dsn::defer([this, app]() {
Review Comment:
The memory state will be updated [1] after get data from ZK successfully in
line 721, why update it again?
1.
https://github.com/apache/incubator-pegasus/blob/master/src/meta/duplication/meta_duplication_service.cpp#L787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
