acelyc111 commented on code in PR #2066:
URL:
https://github.com/apache/incubator-pegasus/pull/2066#discussion_r1695517287
##########
src/meta/duplication/meta_duplication_service.cpp:
##########
@@ -701,6 +702,10 @@ void meta_duplication_service::recover_from_meta_state()
_meta_svc->get_meta_storage()->get_children(
get_duplication_path(*app),
[this, app](bool node_exists, const std::vector<std::string>
&dup_id_list) {
+ dsn::defer([this, app]() {
Review Comment:
Correctness and consistent is important. Update the `duplicating` status to
ZK is not very difficult if all duplications removed.
Or, if the `duplicating` memory status can be recovered from
`<app>/duplication` ZK path, just competely remove the `duplicating` status
from ZK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
