ninsmiracle commented on code in PR #2101:
URL:
https://github.com/apache/incubator-pegasus/pull/2101#discussion_r1721291462
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -250,6 +250,9 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
// Because DUPLICATE comes from other clusters should not be
forwarded to any other
// destinations. A DUPLICATE is meant to be targeting only one
cluster.
continue;
+ } else if (rpc_code == dsn::apps::RPC_RRDB_RRDB_BULK_LOAD) {
Review Comment:
In other words, if there is only one cluster, if there is both nomral
writing and bulkload (without ingest_behind parameter), it may also cause
inconsistency between actual data and expected data.
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -250,6 +250,9 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
// Because DUPLICATE comes from other clusters should not be
forwarded to any other
// destinations. A DUPLICATE is meant to be targeting only one
cluster.
continue;
+ } else if (rpc_code == dsn::apps::RPC_RRDB_RRDB_BULK_LOAD) {
Review Comment:
The current situation will not stop normal writing. And it may make some
inconsistent data between 2 clusters.
In general, we will inform users that this is a situation that will lead to
data inconsistency between master-cluster and backup-cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
