acelyc111 commented on code in PR #2101:
URL:
https://github.com/apache/incubator-pegasus/pull/2101#discussion_r1721311811
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -250,6 +250,9 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
// Because DUPLICATE comes from other clusters should not be
forwarded to any other
// destinations. A DUPLICATE is meant to be targeting only one
cluster.
continue;
+ } else if (rpc_code == dsn::apps::RPC_RRDB_RRDB_BULK_LOAD) {
Review Comment:
So it's better to deny bulkloading on a duplicating table (you can permit
this risk in you own way).
This patch's change looks good to me.
##########
src/server/pegasus_mutation_duplicator.cpp:
##########
@@ -250,6 +250,9 @@ void
pegasus_mutation_duplicator::duplicate(mutation_tuple_set muts, callback cb
// Because DUPLICATE comes from other clusters should not be
forwarded to any other
// destinations. A DUPLICATE is meant to be targeting only one
cluster.
continue;
+ } else if (rpc_code == dsn::apps::RPC_RRDB_RRDB_BULK_LOAD) {
Review Comment:
How about defining a set which contains RPC_RRDB_RRDB_DUPLICATE and
RPC_RRDB_RRDB_BULK_LOAD? Please add some more comments as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
