empiredan commented on code in PR #2085:
URL:
https://github.com/apache/incubator-pegasus/pull/2085#discussion_r1728225927
##########
src/shell/command_helper.h:
##########
@@ -709,30 +709,68 @@ inline std::vector<dsn::http_result> get_metrics(const
std::vector<node_desc> &n
return results;
}
+// Adapt the result returned by `get_metrics` into the structure that could be
processed by
+// `remote_command`.
+template <typename... Args>
+inline std::pair<bool, std::string> process_get_metrics_result(const
dsn::http_result &result,
Review Comment:
OK, use `error_s` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
