empiredan commented on code in PR #2085:
URL:
https://github.com/apache/incubator-pegasus/pull/2085#discussion_r1728229332
##########
src/shell/commands/node_management.cpp:
##########
@@ -232,6 +234,160 @@ dsn::metric_filters rw_requests_filters()
return filters;
}
+dsn::metric_filters server_stat_filters()
+{
+ dsn::metric_filters filters;
+ filters.with_metric_fields = {dsn::kMetricNameField,
dsn::kMetricSingleValueField};
+ filters.entity_types = {"server"};
+ filters.entity_metrics = {"virtual_mem_usage_mb", "resident_mem_usage_mb"};
+ return filters;
+}
+
+struct meta_server_stats
+{
+ meta_server_stats() = default;
+
+ double virt_mem_mb{0.0};
+ double res_mem_mb{0.0};
+
+ DEFINE_JSON_SERIALIZATION(virt_mem_mb, res_mem_mb)
+};
+
+std::pair<bool, std::string>
+aggregate_meta_server_stats(const node_desc &node,
+ const dsn::metric_query_brief_value_snapshot
&query_snapshot)
+{
+ aggregate_stats_calcs calcs;
+ meta_server_stats stats;
+ calcs.create_assignments<total_aggregate_stats>(
+ "server",
+ stat_var_map({{"virtual_mem_usage_mb", &stats.virt_mem_mb},
+ {"resident_mem_usage_mb", &stats.res_mem_mb}}));
+
+ auto command_result = process_parse_metrics_result(
+ calcs.aggregate_metrics(query_snapshot), node, "aggregate meta server
stats");
+ if (!command_result.first) {
+ // Metrics failed to be aggregated.
+ return command_result;
+ }
+
+ return std::make_pair(true,
+
dsn::json::json_forwarder<meta_server_stats>::encode(stats).to_string());
+}
+
+struct replica_server_stats
Review Comment:
Actually they are different, since more metrics would be introduced later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
