empiredan commented on code in PR #2302:
URL:
https://github.com/apache/incubator-pegasus/pull/2302#discussion_r2446649612
##########
src/meta/meta_state_service_zookeeper.cpp:
##########
@@ -199,7 +200,7 @@
meta_state_service_zookeeper::new_transaction_entries(unsigned int capacity)
tsk,
\
std::placeholders::_1);
\
op->_optype = op_type;
\
- input->_path = node;
+ input->_path = std::make_shared<std::string>(node)
Review Comment:
`input->_path = std::make_shared<std::string>(node)` is the **last
statement** in the function-like macro **`VISIT_INIT(tsk, op_type, node)`**.
This macro is always used in the form `VISIT_INIT(...);`, i.e., followed by a
semicolon. Therefore, the final statement inside the macro **should not** end
with a semicolon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
