empiredan commented on code in PR #2302:
URL:
https://github.com/apache/incubator-pegasus/pull/2302#discussion_r2464320586
##########
src/meta/test/meta_state/meta_state_service.cpp:
##########
@@ -61,87 +62,112 @@ void provider_basic_test(const service_creator_func
&service_creator,
const service_deleter_func &service_deleter)
{
// environment
- auto service = service_creator();
+ auto *service = service_creator();
// bondary check
- service->node_exist("/", META_STATE_SERVICE_SIMPLE_TEST_CALLBACK,
expect_ok)->wait();
Review Comment:
Indeed. At first, I didn’t plan to modify it — I thought it would be fine to
keep the default argument.
However, since the virtual function in the `meta_state_service` class isn’t
called in many places and can be easily updated, I decided to follow
`clang-tidy`’s suggestion and make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
