acelyc111 opened a new pull request, #2401:
URL: https://github.com/apache/incubator-pegasus/pull/2401
## Summary
The branch filter `'v[0-9]+.*'` used in 15 workflow files **never matches
any release branch**, because GitHub Actions branch filters use glob syntax
(not regex):
- `+` is a **literal character**, not a quantifier
- `[0-9]` matches **exactly one** digit, not "one or more"
As a result, PRs targeting release branches like `v2.5` silently skip every
workflow that has this filter, while only those without `branches:` filters
(e.g., the Golang/Labeler ones) actually run.
## Evidence
**PR #2394** targets `v2.5` and modifies `src/replica/duplication/**` (C++
code):
- ✅ Triggered: `Golang Lint and Unit Test - admin-cli/pegic`, `Module
Labeler` (no `branches` filter)
- ❌ Did NOT trigger: `Cpp CI`, `Lint and Test - admin-cli` (cli proper),
`Lint and Test - go-client`, etc.
Confirmed historically:
```
$ gh run list --repo apache/incubator-pegasus \
--workflow lint_and_test_cpp.yaml --branch v2.5 --limit 5
(empty — never run)
```
`Cpp CI` has **never run on the v2.5 branch** since the workflow was added.
## Fix
Replace `'v[0-9]+.*'` with `'v[0-9]*'`, which is valid GitHub Actions glob
syntax and matches `v2.5`, `v2.5.1`, `v10.20`, etc.
Applied uniformly to all 15 affected workflows (mechanical sed replacement,
one-line change per file).
## Verification
- [x] All 18 workflow YAMLs parse successfully (`yaml.safe_load`)
- [x] Diff is minimal: 15 files changed, +15/-15
- [ ] After merge: backport to active release branches (`v2.5`, etc.) so
existing release-branch PRs start running full CI
## Notes
This fix on `master` does not change behavior for `master`-targeted PRs
(they already match the first `- master` line). The benefit materializes once
the change is backported to release branches, after which release-branch PRs
will trigger the full CI matrix as originally intended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
