acelyc111 commented on PR #2401:
URL: 
https://github.com/apache/incubator-pegasus/pull/2401#issuecomment-4546250386

   ## Closing — original diagnosis was wrong
   
   After deeper investigation, the premise of this PR is incorrect:
   
   **1. `v[0-9]+.*` actually does match `v2.5`.** GitHub Actions branch filters 
tolerate this glob shape and successfully match release branches like `v2.5`. 
PR #2394's `Cpp CI` workflow **was triggered** (run 
https://github.com/apache/incubator-pegasus/actions/runs/24079456724), it just 
doesn't show up in the PR Checks UI because of (2) below.
   
   **2. The reason `Cpp CI` doesn't appear in PR #2394's Checks UI:** the 
workflow run ended in `conclusion: startup_failure` with an empty `jobs` array. 
When a run fails before any job is created, GitHub doesn't emit any 
`check_run`, so the PR's Checks UI has nothing to display.
   
   **3. The actual root cause of `startup_failure`:** the **ASF GitHub Actions 
allow-list policy** (effective 2025-08-01, see 
[INFRA-27084](https://issues.apache.org/jira/browse/INFRA-27084)). On v2.5, 
workflows still reference unpinned third-party actions like 
`dorny/paths-filter@v2`, `actions/checkout@v3`, etc., which are blocked by the 
org-level policy. The error message reads:
   
   > `The action dorny/paths-filter@v2 is not allowed in 
apache/incubator-pegasus because all actions must be ... or match one of the 
patterns: ...`
   
   This is exactly what #2398 fixed on master (pinning every action to a SHA 
from the ASF allow-list, plus restructuring some workflows to use local 
composite actions).
   
   ## Correct fix
   
   I'll open a new PR **targeting v2.5** that backports #2398-style SHA pinning 
of all third-party actions. Sorry for the noise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to