acelyc111 opened a new pull request, #2402:
URL: https://github.com/apache/incubator-pegasus/pull/2402
## Summary
Backport of #2401 to `v2.5`.
The branch filter `'v[0-9]+.*'` used in workflow files **never matches the
`v2.5` branch**, because GitHub Actions branch filters use glob syntax (not
regex):
- `+` is a **literal character**, not a quantifier
- `[0-9]` matches **exactly one** digit, not "one or more"
As a result, PRs targeting `v2.5` silently skip every workflow that has this
filter, while only those without `branches:` filters (e.g., the Golang/Labeler
ones) actually run.
## Evidence
**PR #2394** targets `v2.5` and modifies `src/replica/duplication/**` (C++
code):
- ✅ Triggered: `Golang Lint and Unit Test - admin-cli/pegic`, `Module
Labeler` (no `branches` filter)
- ❌ Did NOT trigger: `Cpp CI`, `Lint and Test - admin-cli` (cli proper),
`Lint and Test - go-client`, etc.
Confirmed historically:
```
$ gh run list --repo apache/incubator-pegasus \
--workflow lint_and_test_cpp.yaml --branch v2.5 --limit 5
(empty — never run)
```
`Cpp CI` has **never run on the `v2.5` branch** since the workflow was added.
## Fix
Replace `'v[0-9]+.*'` with `'v[0-9]*'`, which is valid GitHub Actions glob
syntax and matches `v2.5`, `v2.5.1`, `v10.20`, etc. Applied uniformly to all 14
affected workflows on `v2.5` (mechanical sed replacement, one-line change per
file).
## Self-validating
This PR modifies `.github/workflows/lint_and_test_cpp.yaml`, which matches
`Cpp CI`'s own `paths:` filter. Combined with the branch glob fix on `v2.5`,
**this PR itself should be the first time `Cpp CI` ever runs on a `v2.5` PR** —
providing direct, in-band proof that the fix works.
## Verification
- [x] All workflow YAMLs parse successfully (`yaml.safe_load`)
- [x] Diff is minimal: 14 files changed, +14/-14
- [ ] After this PR is opened: confirm `Cpp CI` actually appears in the
checks list (proof the fix works)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
