Thanks Justin for your review. Regarding the KafkaClusterSharding.scala file: we sought advice about this file in this JIRA
https://issues.apache.org/jira/browse/LEGAL-648 The advice indicated that when we have code in a source file that has multiple sources and 2 of those sources need Apache license headers that we don't need to add 2 headers. This KafkaClusterSharding.scala file has code from Lightbend Akka (ASL license) and from Apache Kafka (ASL license). Since we already have an ASL license, do we need to add a 2nd one? Regarding the signing key: I was able to validate the .asc files and the key used was the 3FD458B4420059F1F97C2563F6A21ED3A05F7F7B key that appears in https://dist.apache.org/repos/dist/dev/incubator/pekko/KEYS I get this: find . -name "*.asc" -exec gpg --no-secmem-warning --verify {} \; gpg: assuming signed data in './apache-pekko-connectors-kafka-1.0.0-incubating-src-20230726.zip' gpg: Signature made Wed 26 Jul 11:43:04 2023 IST gpg: using RSA key 3FD458B4420059F1F97C2563F6A21ED3A05F7F7B gpg: Good signature from "Matthew de Detrich (CODE SIGNING KEY) <mdedetr...@apache.org>" [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: 3FD4 58B4 4200 59F1 F97C 2563 F6A2 1ED3 A05F 7F7B gpg: assuming signed data in './apache-pekko-connectors-kafka-1.0.0-incubating-src-20230726.tgz' gpg: Signature made Wed 26 Jul 11:42:57 2023 IST gpg: using RSA key 3FD458B4420059F1F97C2563F6A21ED3A05F7F7B gpg: Good signature from "Matthew de Detrich (CODE SIGNING KEY) <mdedetr...@apache.org>" [unknown] gpg: WARNING: This key is not certified with a trusted signature! gpg: There is no indication that the signature belongs to the owner. Primary key fingerprint: 3FD4 58B4 4200 59F1 F97C 2563 F6A2 1ED3 A05F 7F7B On Thu, 27 Jul 2023 at 02:25, Justin Mclean <jus...@classsoftware.com> wrote: > > HI, > > -1 (binding) as I unable to check the signatures. I assume the KEYS file just > needs to be updated? > > I checked: > - incubating in name > - can’t verify signatures, hashes are fine > - LICENSE and NOTICE are OK > - All files have headers but some .conf and .xml could have them added > - Does this file have teh correct header f it was derived from an ASF > project? [1] > - no unexpected binary files > - can compile from code > > There is no need to repeat "This product includes software developed at The > Apache Software Foundation (https://www.apache.org/).” in the NOTICE file. > > Kind Regards, > Justin > > 1. > ./cluster-sharding/src/main/scala/org/apache/pekko/kafka/cluster/sharding/KafkaClusterSharding.scala > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
