I just noticed that the artifact name generated for the sbt plugin is not consistent/correct with the rest of the artifacts.
I am creating a PR to resolve this but it requires a new RC round so, I will block this -1 from me On Fri, Aug 11, 2023 at 10:57 AM PJ Fanning <fannin...@gmail.com> wrote: > Hi Justin, > > I previously raised this issue [1] with Legal and I thought the > consensus was that we do need to add license headers to files when > there were no license headers in those files when we picked them up > from Akka. > > I don't see why we should be forced to add headers to files where none > existed in the first place. > > [1] https://issues.apache.org/jira/browse/LEGAL-649 > > On Fri, 11 Aug 2023 at 06:05, Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > > -1 (binding) because some more work is needed on the file headers. Can > someone explain what is going on with the .proto files and if this was > intentional or not? > > > > I checked: > > - incubating in name > > - DISCLAIMER exist > > - LICENSE and NOTICE are OK (but license may be missing files - see > below) > > - signatures and hashes are fine > > - There is about 40 .proto files than either do not have a header or > have a Copyright Lightbend Inc. / Copyright gRPC Authors header. > > - no unexpected binary files > > - can compile from source > > > > Kind Regards, > > Justin > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
