> -1 (binding) because some more work is needed on the file headers > There is about 40 .proto files than either do not have a header or have a Copyright Lightbend Inc. / Copyright gRPC Authors header.
Regarding the headers, its already been discussed that files derived from Akka which originally did not have a header does not necessarily require a header (see https://issues.apache.org/jira/browse/LEGAL-649?focusedCommentId=17745457&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17745457 ) On Fri, Aug 11, 2023 at 7:05 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) because some more work is needed on the file headers. Can > someone explain what is going on with the .proto files and if this was > intentional or not? > > I checked: > - incubating in name > - DISCLAIMER exist > - LICENSE and NOTICE are OK (but license may be missing files - see below) > - signatures and hashes are fine > - There is about 40 .proto files than either do not have a header or have > a Copyright Lightbend Inc. / Copyright gRPC Authors header. > - no unexpected binary files > - can compile from source > > Kind Regards, > Justin > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
