And if anyone is interested in the bytecode diffs they can look at https://github.com/apache/incubator-pekko-http/pull/418#issuecomment-1894791312
On Wed, Jan 17, 2024 at 12:09 PM Matthew de Detrich < matthew.dedetr...@aiven.io> wrote: > Oh and I forgot to mention that I was using JDK 8 for the benchmarks since > this > is where the Scala2 inliner makes different impacts, latest version of > JDK's should > do a better job of inlining problematic bytecode generated by Scala but a > significant > part of our user base is still running JDK8. > > On Wed, Jan 17, 2024 at 12:07 PM Matthew de Detrich < > matthew.dedetr...@aiven.io> wrote: > >> Since the inliner has been merged into both Pekko and Pekko Http I >> decided to post some results for pekko-http's jmh bench when all of the >> inlining settings are applied (left is without inliner, right is with >> inliner) >> >> Against Pekko 1.0.2: https://www.diffchecker.com/iH0WbWNZ/ >> Against Pekko 1.0.0-M1 (current main): >> https://www.diffchecker.com/XhyEC556/ >> >> As you can see from the results there are some noticeable improvements >> (i.e. 5-10% in some cases) however I wouldn't take these results as >> complete gospel as I had to do the benchmarks on my M1 laptop (I had it in >> power plus used TGPro to put fans on max blast to reduce any variability, >> unfortunately I am currently overseas so I don't have a dedicated machine >> to test on). >> >> This testing was a result of valid concerns raised by Johannes[1]. >> Another valid point being raised is about being diligent when it comes to >> performance/benchmarks which is what dedicated hardware for benchmarking >> was meant to solve. PJ Fanning has set up an open collective for Pekko[2] >> and there is already a github discussion[3] about it. >> >> So maybe now is a good time to start talking about funding for the Pekko >> project in general as well as being a call to action to any heavy users of >> Pekko that feel like donating? The initial plan was to use the funds to >> procure dedicated HW from hetzner (https://www.hetzner.com/) with >> dedicated bare metal machines costing 50-100 euros a month, with one >> machine being used for nightly builds and another machine dedicated to >> benchmarking. >> >> We can also discuss what the additional funds can be used for (i.e. >> sponsoring core maintainers, talks/conferences once Pekko gets big enough >> etc etc?) although that might be best for another thread. >> >> Thoughts? >> >> [1]: >> https://github.com/apache/incubator-pekko-http/pull/418#issuecomment-1893375856 >> [2]: https://opencollective.com/friends-of-apache-pekko >> [3]: https://github.com/apache/incubator-pekko/discussions/144 >> -- >> >> Matthew de Detrich >> >> *Aiven Deutschland GmbH* >> >> Immanuelkirchstraße 26, 10405 Berlin >> >> Alexanderufer 3-7, 10117 Berlin >> >> Amtsgericht Charlottenburg, HRB 209739 B >> >> Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen >> >> *m:* +491603708037 >> >> *w:* aiven.io *e:* matthew.dedetr...@aiven.io >> > > > -- > > Matthew de Detrich > > *Aiven Deutschland GmbH* > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > *m:* +491603708037 > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > -- Matthew de Detrich *Aiven Deutschland GmbH* Immanuelkirchstraße 26, 10405 Berlin Alexanderufer 3-7, 10117 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen *m:* +491603708037 *w:* aiven.io *e:* matthew.dedetr...@aiven.io
