On Thu, Jan 18, 2024 at 12:48 AM Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> wrote: > it will automatically inline any code that it knows won't get inlined by the > JDK
It will only do that in some select few cases. > In any case, I would still opt for leaving the inliner in there. I would be > extremely > shocked if there are any correctness issues given that its being used for > at least > half a decade in many projects See https://github.com/apache/incubator-pekko-http/pull/456 for an example of the correctness issue. Afaik none of the many projects enable the inliner for development. > hence the "free lunch" argument and the > complexity is not that high (we are dealing with some extra scalac flags) I would not call it free lunch, especially since the development efficiency is impacted by far longer compile times and potential correctness issues. If we decide to run the inliner on CI and for releases, then this will introduce another level of complexity to important steps of the release pipeline building differently in different situations. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
