The vote has moved onto the Incubator list and still incomplete there. I have gone through multiple discussions with Legal and other teams and I still argue that not all files should have Apache headers.
https://cwiki.apache.org/confluence/display/PEKKO/Not+all+Apache+Pekko+Files+Need+Headers The TLDR of this is that if the file is not written by the Pekko team, we can choose to keep the headers of the original file. The files without headers did not have headers to begin with. Do we need to get Legal involved again? On Sat, 20 Jan 2024 at 13:07, Claude Warren, Jr <claude.war...@aiven.io.invalid> wrote: > > I know I am late to the party. I promised Matthew that I would review it > this weekend and I have found some issues. > > The attached report is from the RAT tool. I know that there is a lot of > stuff that can (and should) be ignored so I will list the issues in > descending blocks of importance > > Critical: > > release (not test) scala files that do not contain the ASF License Header. > release (not test) scripts that do not contain the ASF License Header. > apache-pekko-connectors-1.0.2-incubating-src-20240109/ftp/src/test/resources/sftpd/init.sh > copies keys not present in the package into the /etc/ssh directory and makes > them available to the system. There does not appear to be documentation for > this script and no comments in it. > > Warning: > > documentation files without ASF License Headers. > xml files withthoug ASF License Headers. > test scripts that do not contains the ASF License Header > > Info: > > private keys in the test packaging. These should be documented and/or > removed. Perhaps replaced with scripts that will generate keys specifically > named for the application/extension. > > I did not go into much depth in this review as the voting was already closed > and I suspect the release completed. > > Claude > > On Fri, Jan 12, 2024 at 8:18 PM PJ Fanning <fannin...@apache.org> wrote: >> >> The vote passes with 4 +1s and no negative votes. All votes were from >> Pekko PPMC members. >> >> Vote Thread >> https://lists.apache.org/thread/nosrvwphtwmcg7dw9pz6y1qbtm3zhgpn >> >> Votes >> He Pin (kerr) >> Matthew de Detrich >> Nicolas Vollmar >> PJ Fanning >> >> The next stage is to have a vote on the Incubator general mailing list. >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org >> For additional commands, e-mail: dev-h...@pekko.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
