My statement stands: In general _ALL_ ASF source code should have an ASF license header In Pekko's case there are agreements in place for code that existed before the ASF project started and that was not granted.
So far we are in violent agreement (I think). The issue arises with files that have significant changes. There are several cases with .md files where the contents of the file is mostly changed. These should have the ASF headers. The scripts that were written for Pekko usage, for example running GitHub actions, should have the ASF headers. These are the items I was pointing to in my report. Claude On Mon, Jan 22, 2024 at 12:09 PM kerr <hepin1...@gmail.com> wrote: > For the file license header, if the origin code is not published under > apache license , we should not put apache header on it. > > 何品 > > > Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> 于2024年1月22日周一 > 18:48写道： > > > > In general _ALL_ ASF source code should have an ASF license header. > > There > > was agreement on what that should look like with legal, so stick with > > that. I think the report I submitted lists files that do not have the > > headers. Perhaps I am mistaken, in which case I will fix the report and > run > > it again. > > > > This actually wasn't the agreement, it was decided that we actually > > shouldn't > > generally put the ASF license header on all ASF code if that code was > > written by > > a 3rd party since putting the license header has a risk of > > relicensing/changing > > the legal status of the source code and it also places an undue burden on > > Pekko > > developers. > > > > Please see ticket LEGAL-649[1], specifically > > > > > https://issues.apache.org/jira/browse/LEGAL-649?focusedCommentId=17745457&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17745457 > > > > [1]https://issues.apache.org/jira/browse/LEGAL-649 > > > > On Mon, Jan 22, 2024 at 9:28 PM Claude Warren, Jr > > <claude.war...@aiven.io.invalid> wrote: > > > > > My comments were not meant to stop the release. The report I submitted > > was > > > to give the team some idea of where the problems might be. I think > that > > > documenting in README and LICENSE files should cover most of the cases. > > > > > > In general _ALL_ ASF source code should have an ASF license header. > > There > > > was agreement on what that should look like with legal, so stick with > > > that. I think the report I submitted lists files that do not have the > > > headers. Perhaps I am mistaken, in which case I will fix the report and > > run > > > it again. > > > > > > I think the tar file is fine. But I also think a README in the > directory > > > with the key files and the tar file would help significantly in > > explaining > > > what is going on in those cases. > > > > > > Looking though the diff between the current head and the original fork > I > > > can see that most of the .md files have been edited. They should have > > ASF > > > or the legal agreed ASF headers in them. Some have been so > significantly > > > rewritten that they should have the ASF header in my opinion. Some > files > > > are new, and they are missing the ASF headers. > > > > > > If you want I can build a list of all the files I think should have one > > of > > > the two headers. > > > > > > > > > On Sat, Jan 20, 2024 at 5:06 PM PJ Fanning <fannin...@gmail.com> > wrote: > > > > > > > I created > > > https://github.com/apache/incubator-pekko-connectors/issues/320 > > > > to discuss the nested-sample.tar file. > > > > > > > > It might be best to discuss the file there but in short, I think it > is > > > > ok to include this file as it is not a compiled file. Deleting the > > > > file and creating it as part of the test is complicated because the > > > > tar is meant to be complicated in order to test the feature. > > > > > > > > > > > > On Sat, 20 Jan 2024 at 15:08, PJ Fanning <fannin...@gmail.com> > wrote: > > > > > > > > > > I added > > https://github.com/apache/incubator-pekko-connectors/pull/317 > > > > > > > > > > I think that this is a real nail gun situation. At some point, you > > > > > have to say the users are responsible for understanding what they > are > > > > > doing before running scripts. > > > > > We need this file for our unit testing but I guess we can add some > > > > warnings. > > > > > > > > > > I don't really feel we can take the 10+ years of tests that we have > > > > > inherited from Akka and write up a beginners guide to how to run > all > > > > > of them. It is more efficient for us to answer contributor > questions > > > > > than to proactively developer docs. Pekko Connectors is made up of > > 40+ > > > > > barely related integrations. The developer docs would be huge and > > many > > > > > developers can piece together what they need from looking at the > > > > > GitHub workflow scripts and I think you will find that we provide > > > > > quick answers to any questions that come in. > > > > > > > > > > On Sat, 20 Jan 2024 at 14:31, PJ Fanning <fannin...@apache.org> > > wrote: > > > > > > > > > > > > The vote has moved onto the Incubator list and still incomplete > > > there. > > > > > > > > > > > > I have gone through multiple discussions with Legal and other > teams > > > > > > and I still argue that not all files should have Apache headers. > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/PEKKO/Not+all+Apache+Pekko+Files+Need+Headers > > > > > > > > > > > > The TLDR of this is that if the file is not written by the Pekko > > > team, > > > > > > we can choose to keep the headers of the original file. The files > > > > > > without headers did not have headers to begin with. > > > > > > > > > > > > Do we need to get Legal involved again? > > > > > > > > > > > > On Sat, 20 Jan 2024 at 13:07, Claude Warren, Jr > > > > > > <claude.war...@aiven.io.invalid> wrote: > > > > > > > > > > > > > > I know I am late to the party. I promised Matthew that I would > > > > review it this weekend and I have found some issues. > > > > > > > > > > > > > > The attached report is from the RAT tool. I know that there > is a > > > > lot of stuff that can (and should) be ignored so I will list the > issues > > > in > > > > descending blocks of importance > > > > > > > > > > > > > > Critical: > > > > > > > > > > > > > > release (not test) scala files that do not contain the ASF > > License > > > > Header. > > > > > > > release (not test) scripts that do not contain the ASF License > > > > Header. > > > > > > > > > > > > > > > > > apache-pekko-connectors-1.0.2-incubating-src-20240109/ftp/src/test/resources/sftpd/init.sh > > > > copies keys not present in the package into the /etc/ssh directory > and > > > > makes them available to the system. There does not appear to be > > > > documentation for this script and no comments in it. > > > > > > > > > > > > > > Warning: > > > > > > > > > > > > > > documentation files without ASF License Headers. > > > > > > > xml files withthoug ASF License Headers. > > > > > > > test scripts that do not contains the ASF License Header > > > > > > > > > > > > > > Info: > > > > > > > > > > > > > > private keys in the test packaging. These should be documented > > > > and/or removed. Perhaps replaced with scripts that will generate > keys > > > > specifically named for the application/extension. > > > > > > > > > > > > > > I did not go into much depth in this review as the voting was > > > > already closed and I suspect the release completed. > > > > > > > > > > > > > > Claude > > > > > > > > > > > > > > On Fri, Jan 12, 2024 at 8:18 PM PJ Fanning < > fannin...@apache.org > > > > > > > wrote: > > > > > > >> > > > > > > >> The vote passes with 4 +1s and no negative votes. All votes > were > > > > from > > > > > > >> Pekko PPMC members. > > > > > > >> > > > > > > >> Vote Thread > > > > > > >> > > https://lists.apache.org/thread/nosrvwphtwmcg7dw9pz6y1qbtm3zhgpn > > > > > > >> > > > > > > >> Votes > > > > > > >> He Pin (kerr) > > > > > > >> Matthew de Detrich > > > > > > >> Nicolas Vollmar > > > > > > >> PJ Fanning > > > > > > >> > > > > > > >> The next stage is to have a vote on the Incubator general > > mailing > > > > list. > > > > > > >> > > > > > > >> > > > > --------------------------------------------------------------------- > > > > > > >> To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > >> For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > >> > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > -- > > > > Matthew de Detrich > > > > *Aiven Deutschland GmbH* > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Alexanderufer 3-7, 10117 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > *m:* +491603708037 > > > > *w:* aiven.io *e:* matthew.dedetr...@aiven.io > > >
