I don't agree that we want to build Pekko gRPC 1.1 off of Pekko 1.1.0-M1. Pekko 1.1.0-M1 is * a milestone - not a proper release * I thought we were trying to maintain it so that our modules would be compatible with Pekko 1.0
I don't see the need for a milestone release of Pekko gRPC. There is nothing experimental in the main branch. The only reason to make this a 1.1 release instead of 1.0.3 release is that the changes in our Protobuf dependencies are not trivial. On Tue, 19 Mar 2024 at 07:12, Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> wrote: > > I would wait till Pekko Core 1.1.0-M1 release so that gRPC 1.1.0 can > build off of Pekko Core 1.1.0-M1 > as this will enable the full cross inlining[1]. > > Also not sure if we want to do -M1 first before full release (or not). > The reasons here are weaker than > other projects but I may be missing something. > > 1: > https://github.com/pjfanning/sbt-pekko-build/blob/main/src/main/scala/com/github/pjfanning/pekkobuild/PekkoInlinePlugin.scala#L49-L56 > > On Mon, Mar 18, 2024 at 9:26 PM PJ Fanning <fannin...@apache.org> wrote: > > > > Hi everyone, > > > > The gRPC code is heavily dependent on protobuf and there are upgrades > > to grpc-protobuf and protoc in the main branch. With the 2 gRPC based > > Pekko Connectors that we maintain, we are already blocked from > > upgrading some Google libs - because they are incompatible with the > > Pekko gRPC jars. These connectors will compile with the latest Google > > jars if Pekko gRPC 1.1 snapshots are used. > > > > These projects demo this: > > * https://github.com/pjfanning/pekko-connectors-google-cloud-pub-sub-grpc/ > > * > > https://github.com/pjfanning/pekko-connectors-google-cloud-bigquery-storage > > > > There has recently been a new protobuf-java 4.0.26 release but the > > gRPC and other libs have been changed to support this incompatible > > version. I suspect that we might need a Pekko gRPC release for these > > new protobuf-java 4.0,x releases at some point also. > > > > Does anyone have any thoughts about this? > > > > Regards, > > PJ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > -- > > Matthew de Detrich > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491603708037 > > w: aiven.io e: matthew.dedetr...@aiven.io > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org For additional commands, e-mail: dev-h...@pekko.apache.org
