I did not see (or appreciate the repercussions of) https://github.com/apache/incubator-pekko/pull/857.
I do not think we should claim Pekko modules such as gRPC are compatible with older versions of Pekko Core than the version they are built against. Claiming that would essentially mean Pekko Core would have to be forwards compatible (code compiled against new versions should work with old versions) as well as backwards compatible (code compiled against old versions should work with new versions). While that might be trivially true for the inlining change, I don't think we should take on that responsibility generally. I understand it's disappointing that that means we won't see the full benefits of the inliner until we bump the required Pekko Core version in gRPC to Pekko 1.1.0 - but I do think it's the sensible choice. Kind regards, Arnout On Tue, Mar 19, 2024 at 12:58 PM Matthew de Detrich <matthew.dedetr...@aiven.io.invalid> wrote: > And to be clear, this was discussed all the way back when the PR was > originally > made at https://github.com/apache/incubator-pekko/pull/857, quoting > directly > > > It may be that for the Pekko module 1.1.x series they will have to build > against Pekko core 1.1.x because while the > @inline annotations existed in Pekko 1.0.x, the inline keyword for > Scala 3 in various places was only added in Scala 3. This however > shouldn't cause any issues because a Pekko module built against Pekko > core 1.1.x would inline all relevant code, so even if a Pekko core > 1.0.x is linked at runtime in a Pekko 1.1.x module, all it means is > that the Pekko 1.0.x will bring in some unused code. > > On Tue, Mar 19, 2024 at 12:51 PM Matthew de Detrich > <matthew.dedetr...@aiven.io> wrote: > > > > > I agree, no release of a module should depend on an unreleased version > of > > Pekko. > > > > This is incorrect, -M1 is technically an ASF release. Having pekko-grpc > rely > > on a non released version of Pekko is not what is being discussed and > > never was on the table. > > > > > This Pekko 1.1 build set up has never been agreed on. I'm against it > > due to its complexity and unproven benefits. > > > > This is the same build setup that is required to cross test pekko against > > multiple pekko versions which was also discussed in multiple other > places. > > > > I have a suspicion that you have an inaccurate impression of whats being > > discussed, its really not that complex. The minimum build version will > be set > > to Pekko 1.1.0 or Pekko 1.1.0-M1 and another pipeline will be added to > run > > it against Pekko 1.0.x which we were planning to do anyways. > > > > On Tue, Mar 19, 2024 at 12:46 PM Nicolas Vollmar <nvoll...@gmail.com> > wrote: > > > > > > I agree, no release of a module should depend on an unreleased version > of > > > Pekko. > > > People would end up with unintended milestones in their class path. > > > > > > If gRPC 1.1 needs Pekko 1.1 we should push for that release first. > > > > > > On Tue, 19 Mar 2024 at 12:01, PJ Fanning <fannin...@gmail.com> wrote: > > > > > > > This Pekko 1.1 build set up has never been agreed on. I'm against it > > > > due to its complexity and unproven benefits. > > > > > > > > On Tue, 19 Mar 2024 at 11:54, Matthew de Detrich > > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > > > > This was discussed previously multiple times, in order for the > > > > > inlining to be fully > > > > > enabled it needs to be built with Pekko 1.1.0-M1 because that's the > > > > > version of Pekko > > > > > with the fixed inlining. This does not mean that a pekko gRPC > > > > > built with Pekko 1.1.0-M1 won't work with Pekko 1.0.x, it just > means it > > > > needs to > > > > > be built with it. > > > > > > > > > > Note that this also implies we need to add a test to make sure a > pekko > > > > > gRPC built > > > > > with Pekko 1.1.0-M1 works when linked with Pekko 1.0.x at runtime > > > > > > > > > > On Tue, Mar 19, 2024 at 10:36 AM PJ Fanning <fannin...@apache.org> > > > > wrote: > > > > > > > > > > > > I don't agree that we want to build Pekko gRPC 1.1 off of Pekko > > > > > > 1.1.0-M1. Pekko 1.1.0-M1 is > > > > > > * a milestone - not a proper release > > > > > > * I thought we were trying to maintain it so that our modules > would be > > > > > > compatible with Pekko 1.0 > > > > > > > > > > > > I don't see the need for a milestone release of Pekko gRPC. > There is > > > > > > nothing experimental in the main branch. The only reason to make > this > > > > > > a 1.1 release instead of 1.0.3 release is that the changes in our > > > > > > Protobuf dependencies are not trivial. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, 19 Mar 2024 at 07:12, Matthew de Detrich > > > > > > <matthew.dedetr...@aiven.io.invalid> wrote: > > > > > > > > > > > > > > I would wait till Pekko Core 1.1.0-M1 release so that gRPC > 1.1.0 can > > > > > > > build off of Pekko Core 1.1.0-M1 > > > > > > > as this will enable the full cross inlining[1]. > > > > > > > > > > > > > > Also not sure if we want to do -M1 first before full release > (or > > > > not). > > > > > > > The reasons here are weaker than > > > > > > > other projects but I may be missing something. > > > > > > > > > > > > > > 1: > > > > > https://github.com/pjfanning/sbt-pekko-build/blob/main/src/main/scala/com/github/pjfanning/pekkobuild/PekkoInlinePlugin.scala#L49-L56 > > > > > > > > > > > > > > On Mon, Mar 18, 2024 at 9:26 PM PJ Fanning < > fannin...@apache.org> > > > > wrote: > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > The gRPC code is heavily dependent on protobuf and there are > > > > upgrades > > > > > > > > to grpc-protobuf and protoc in the main branch. With the 2 > gRPC > > > > based > > > > > > > > Pekko Connectors that we maintain, we are already blocked > from > > > > > > > > upgrading some Google libs - because they are incompatible > with > > > > the > > > > > > > > Pekko gRPC jars. These connectors will compile with the > latest > > > > Google > > > > > > > > jars if Pekko gRPC 1.1 snapshots are used. > > > > > > > > > > > > > > > > These projects demo this: > > > > > > > > * > > > > > https://github.com/pjfanning/pekko-connectors-google-cloud-pub-sub-grpc/ > > > > > > > > * > > > > > https://github.com/pjfanning/pekko-connectors-google-cloud-bigquery-storage > > > > > > > > > > > > > > > > There has recently been a new protobuf-java 4.0.26 release > but the > > > > > > > > gRPC and other libs have been changed to support this > incompatible > > > > > > > > version. I suspect that we might need a Pekko gRPC release > for > > > > these > > > > > > > > new protobuf-java 4.0,x releases at some point also. > > > > > > > > > > > > > > > > Does anyone have any thoughts about this? > > > > > > > > > > > > > > > > Regards, > > > > > > > > PJ > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Matthew de Detrich > > > > > > > > > > > > > > Aiven Deutschland GmbH > > > > > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > > > > > Alexanderufer 3-7, 10117 Berlin > > > > > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > > > > > m: +491603708037 > > > > > > > > > > > > > > w: aiven.io e: matthew.dedetr...@aiven.io > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Matthew de Detrich > > > > > > > > > > Aiven Deutschland GmbH > > > > > > > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > > > > > > > Alexanderufer 3-7, 10117 Berlin > > > > > > > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > > > > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > > > > > > > m: +491603708037 > > > > > > > > > > w: aiven.io e: matthew.dedetr...@aiven.io > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > > > > For additional commands, e-mail: dev-h...@pekko.apache.org > > > > > > > > > > > > > > > > -- > > > > Matthew de Detrich > > > > Aiven Deutschland GmbH > > > > Immanuelkirchstraße 26, 10405 Berlin > > > > Alexanderufer 3-7, 10117 Berlin > > > > Amtsgericht Charlottenburg, HRB 209739 B > > > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > > > m: +491603708037 > > > > w: aiven.io e: matthew.dedetr...@aiven.io > > > > -- > > Matthew de Detrich > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Alexanderufer 3-7, 10117 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491603708037 > > w: aiven.io e: matthew.dedetr...@aiven.io > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@pekko.apache.org > For additional commands, e-mail: dev-h...@pekko.apache.org > > -- Arnout Engelen ASF Security Response Apache Pekko PMC member, ASF Member NixOS Committer Independent Open Source consultant
