On Mon, 6 Aug 2001, Doug MacEachern wrote:
> On Sun, 5 Aug 2001, Stas Bekman wrote:
>
> > The following patch implements PerlModule and PerlRequire configuration
> > directives, for the main server and virtual hosts. I apologize for putting
> > both features in one patch, but the two are absolutely identical. having
> > the two in the same patch will probably help to see how to abstract the
> > two and reduce code duplication.
>
> that looks good, but we also need to support Perl{Module,Require}
> in .htaccess as 1.x does. but that can always happen later.
ok
> > Probably the naming convention could be improved as well.
>
> just s/exec/apply/ would be fine. and those functions should not exit(),
> but return TRUE or FALSE and let the caller decide what todo. that will
> be important for .htaccess support.
like this?
if (modperl_config_apply_PerlModule(s, scfg, perl, p) == FALSE){
exit(1);
}
Also what I realize that modperl_require_module already prints the error
to STDERR. So should I remove then:
fprintf(stderr,
"Can't load Perl module `%s' for server %s, exiting...\n",
entries[i], modperl_server_desc(s,p));
so it'll be like this?
if (modperl_require_module(aTHX_ entries[i], TRUE)){
MP_TRACE_i(MP_FUNC, "loaded Perl module %s for server %s\n",
entries[i], modperl_server_desc(s,p));
}
else {
return FALSE;
}
but then we miss the indication : modperl_server_desc(s,p)
also should it try to load other perl modules if any and return false if
at least one fails? or bail out on the first failure?
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
