On Tue, 7 Aug 2001, Stas Bekman wrote:
> like this?
>
> if (modperl_config_apply_PerlModule(s, scfg, perl, p) == FALSE){
> exit(1);
> }
yeah, but 'if (!modperl_config_apply_PerlModule(...)) {' is fine, we never
actually test if something == FALSE or == TRUE, just return those values.
> Also what I realize that modperl_require_module already prints the error
> to STDERR. So should I remove then:
>
> fprintf(stderr,
> "Can't load Perl module `%s' for server %s, exiting...\n",
> entries[i], modperl_server_desc(s,p));
>
> so it'll be like this?
>
> if (modperl_require_module(aTHX_ entries[i], TRUE)){
> MP_TRACE_i(MP_FUNC, "loaded Perl module %s for server %s\n",
> entries[i], modperl_server_desc(s,p));
> }
> else {
> return FALSE;
> }
yeah, but s/MP_TRACE_i/MP_TRACE_d/
> but then we miss the indication : modperl_server_desc(s,p)
you could ap_log_error that on failure.
> also should it try to load other perl modules if any and return false if
> at least one fails? or bail out on the first failure?
bail on the first failure.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
