On Sat, 8 Sep 2001, Philippe M . Chiasson wrote:
> Hi, the following patch tries to implement $r->no_cache() ;-)
implementation is good, just one problem, r->no_cache would get modified
regardless of if a value was passed to $r->no_cache or not. and if no
explicit value was passed, the unsets would still happen if r->no_cache is
0. i fixed it to behave as 1.x does. also, since the default value of
r->no_cache is 0, the test was broken.
and, style is off. have a read of:
http://dev.apache.org/styleguide.html
in particular to your patch:
do: if (
dont: if(
do: if (r->no_cache)
dont: if ( r->no_cache )
do: ("foo", "bar", "baz")
dont: ("foo","bar","baz")
and there was lack of indentation:
+ if( r->no_cache ) {
+ apr_table_setn(r->headers_out,"Pragma","no-cache");
+ apr_table_setn(r->headers_out,"Cache-control", "no-cache");
+ }
but that's easy to fix, you figured out the hard part, good work :)
> The only warning I have, is that I had to modify FunctionTable.pm by hand.
> I was able to run source_scan.pl and regenerate the tables myself, but the
> resulting diff has nothing to do with my change, so here it goes...
that's ok, i'll just rerun it here.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
