On Sat, Sep 08, 2001 at 11:30:05AM -0700, Doug MacEachern wrote:
> On Sat, 8 Sep 2001, Philippe M . Chiasson wrote:
>
> > Hi, the following patch tries to implement $r->no_cache() ;-)
>
> implementation is good, just one problem, r->no_cache would get modified
> regardless of if a value was passed to $r->no_cache or not. and if no
> explicit value was passed, the unsets would still happen if r->no_cache is
> 0. i fixed it to behave as 1.x does. also, since the default value of
> r->no_cache is 0, the test was broken.
> and, style is off. have a read of:
> http://dev.apache.org/styleguide.html
Doh! That's why I normally run all my code thru asf-indent before sending it away.
It's not my favorite style (also why I have gozer-indent), but I like code to
be consistent.
I guess it's been a while since I actively contributed to anything, so I gotta
get my dicipline back. Sorry 'bout that.
> in particular to your patch:
> do: if (
> dont: if(
> do: if (r->no_cache)
> dont: if ( r->no_cache )
> do: ("foo", "bar", "baz")
> dont: ("foo","bar","baz")
>
> and there was lack of indentation:
> + if( r->no_cache ) {
> + apr_table_setn(r->headers_out,"Pragma","no-cache");
> + apr_table_setn(r->headers_out,"Cache-control", "no-cache");
> + }
>
> but that's easy to fix, you figured out the hard part, good work :)
Thanks, more to come.
> > The only warning I have, is that I had to modify FunctionTable.pm by hand.
> > I was able to run source_scan.pl and regenerate the tables myself, but the
> > resulting diff has nothing to do with my change, so here it goes...
>
> that's ok, i'll just rerun it here.
>
>
--
+----------------------------------------------------+
| Philippe M. Chiasson <[EMAIL PROTECTED]> |
+----------------------------------------------------+
| F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5 |
+----------------------------------------------------+
gethostent not implemented : Your C library apparently
doesn't implement gethostent(), probably because if it did,
it'd feel morally obligated to return every hostname on the
Internet.
-- perldiag(1)
perl -e '$$=\${gozer};{$_=unpack(P26,pack(L,$$));/^Just Another Perl
Hacker!\n$/&&print||$$++&&redo}'
PGP signature
