On Sun, 9 Sep 2001, Doug MacEachern wrote:
> On Mon, 10 Sep 2001, Stas Bekman wrote:
>
> > should we change the default log level to notice in Apache::TestTrace?
> > Using warning for things like: "installing foo" doesn't seem right.
>
> we should let make/MakeMaker take care of those messages.
>
> > not sure how clean is this patch, but it installs the right lib, based on
> > the value of MODPERL_LIB. I think this will work for the static build as
> > well.
>
> we should be setting up make variables like $(APACHE_PREFIX),
> $(APACHE_LIBDIR), etc., and using MY::post_initialize to add to
> $self->{PM} (like 1.x does when installing header files). for example:
>
> $self->{PM}{"src/modules/perl/$libmodperl"} =
> "\$(APACHE_LIBDIR)/$libmodperl";
>
> then we can do similar with header files and whatever else we want
> installed under $(APACHE_PREFIX).
the problem is that $code->generate($build); is running in
post_configure(), which means that I don't know $libmodperl (which is
$build->{'MODPERL_LIB'}) during MY::post_initialize.
But is that how it should be? The install code is commented out.
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.37
diff -u -r1.37 Makefile.PL
--- Makefile.PL 2001/08/08 16:38:07 1.37
+++ Makefile.PL 2001/09/10 03:52:07
@@ -23,9 +23,11 @@
NAME => 'mod_perl',
VERSION => $VERSION,
macro => {
- MODPERL_SRC => $code->path,
- PERL => $build->perl_config('perlpath'),
- MOD_INSTALL => ModPerl::MM::mod_install(),
+ MODPERL_SRC => $code->path,
+ PERL => $build->perl_config('perlpath'),
+ MOD_INSTALL => ModPerl::MM::mod_install(),
+ APACHE_PREFIX => $build->apxs('-q' => 'prefix'),
+ APACHE_LIBDIR => $build->apxs('-q' => 'libexecdir'),
},
clean => {
FILES => "@{ clean_files() }",
@@ -239,9 +241,14 @@
sub MY::post_initialize {
my $self = shift;
+
+ my $MODPERL_LIB = $build->{'MODPERL_LIB'} || '';
+
#up one from the Apache2/ subdir
#so it can be found for 'use Apache2 ()'
$self->{PM}->{'lib/Apache2.pm'} = "blib/lib/Apache2.pm";
+# $self->{PM}->{"src/modules/perl/$MODPERL_LIB"} =
+# "\$(APACHE_LIBDIR)/$MODPERL_LIB";
'';
}
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
