On Sun, 9 Sep 2001, Doug MacEachern wrote:
> On Mon, 10 Sep 2001, Stas Bekman wrote:
>
> > But MODPERL_LIB will have .a extension if we make a static build. and
> > $Config{dlext} "hardcodes" dynamic lib extension. Or we don't care now?
>
> we should only install the .so, libmodperl.a is only useful when linked
> into httpd.
But then in case we have the static built make will attempt to install .so
which doesn't exist. So should we then check against MP_USE_DSO?
sub MY::post_initialize {
my $self = shift;
+
+ if ( exists $build->{MP_USE_DSO} && $build->{MP_USE_DSO}) {
+ my $MODPERL_LIB = join '.', $build->{MP_LIBNAME}, $Config{dlext};
+ $self->{PM}->{"src/modules/perl/$MODPERL_LIB"} =
+ "\$(APACHE_LIBDIR)/$MODPERL_LIB";
+ }
+
#up one from the Apache2/ subdir
#so it can be found for 'use Apache2 ()'
$self->{PM}->{'lib/Apache2.pm'} = "blib/lib/Apache2.pm";
> > another thing I'm not quit about is using 'src/modules/perl' -- is it
> > fine to hardcode this path (I know it's a source dir, so it should be
> > the same all the time) and '/' -- shouldn't we use catfile everywhere?
>
> not too worried about either. if catfile really needs to be used
> everywhere, there's plenty of places that need to be changed, and should
> be easy to change. and i'd like to keep it so that the libmodperl is
> always built in the same place (unlike 1.x), so hardcoding the location is
> fine. though it wouldn't hurt to be using a variable stashed in the
> $build object.
ok
> > anyway, here is the new patch (I cannot reach cvs.apache.org now :( ) :
>
> strange, i just made a commit no problems.
ADSL problems on my side. it's ok now.
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
