Stas Bekman wrote:
> this patch is to flex things a bit, so the entries in typemap can be
> aligned for an easier human consumption. Currently this doesn't work:
>
> unsigned long:DEFINE_conn_count | | modperl_worker_score_t *:self
> char *:DEFINE_client | | modperl_worker_score_t *:self
>
> the patch allows this. Or is it better to align?
>
> unsigned long:DEFINE_conn_count | | modperl_worker_score_t *:self
> char * :DEFINE_client | | modperl_worker_score_t *:self
>
> in any case C allows you to say 'type *' why WrapXS shouldn't.
actually the potential trailing spaces should go to:
Index: lib/ModPerl/FunctionMap.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/ModPerl/FunctionMap.pm,v
retrieving revision 1.8
diff -u -r1.8 FunctionMap.pm
--- lib/ModPerl/FunctionMap.pm 3 May 2001 05:41:02 -0000 1.8
+++ lib/ModPerl/FunctionMap.pm 11 Mar 2002 15:48:52 -0000
@@ -114,6 +114,8 @@
if ($name =~ s/^([^:]+)://) {
$return_type = $1;
+ $return_type =~ s/\s{2,}/ /; # allow: char *:....
+ $return_type =~ s/\s+$//; # allow: char * :....
}
if ($name =~ s/^(\W)// or not $cur{MODULE} or $disabled) {
--
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
