On Fri, 21 Jun 2002, Stas Bekman wrote: > But +GlobalRequest gives you $r, Apache->warn and Apache::warn currently > use $s. Do you mean to do global_request + r->server internally instead > of modperl_global_get_server_rec();?
yes. > Well, I've documented all the interfaces that do: > > s = modperl_global_get_server_rec(); > > as to be used at the startup. Any chance (need?) we can enforce that? maybe. > I was also wondering why in the world do we need such a huge number of > ways to do the same thing? > > /* > * we support the following: > * Apache::warn > * Apache->warn > * $r->warn > * $r->log_error > * Apache::Server->log_error > * $s->log_error > * Apache::Server->warn > * $s->warn > */ its really just 2 things: $object->method ClassName->method then same XS() is used for more than one class and more than one method. then the extra Apache::warn which is exported into Apache::Registry script to override warn() > I suggest moving all these to compat and leave: actuall, all of MPXS_Apache__Log_log_error is for compat. so if we drop one, might as well drop them all. Apache::Log is the "proper" api. make it a STATUS item to think about, i don't want to decide this moment what to drop. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
