On Wed, 2003-01-29 at 11:57, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > Made a few minor style changes to the original patches. Thanks for the > > extra eyeballing Stas ;-) > > I've committed the doc after massaging it. Still can't decide what the best > look-n-feel for the API docs to choose, but we are getting there.
Better to have something than nuthin ;-p > Regarding the xs and the test, you still had quite a few indentation problems, > plus too wide lines (keep under 74 or so), but I've fixed those and committed. Hargh ! I am still trying to figure out a way to automatically indent my stuff, but I am failing miserably... Can't get indent to produce mod_perl perfect code... > Finally you've forgotten the table file, but I've grabbed the one from your > previous post, so it's ok. ;) Thanks, and sorry abot that. > Good work, gozer! Now figure out how to get the hash preserve the keys order > ;) I'd put that as a TODO item and in the meantime I'll look if I can just plug Tie::IxHash in there instead of a regular hash. > May be it's better to s/as_hash/as_list/, it's easy to coerce a list into a > hash. Hmm... Not sure it would be any better. Really, as_hash is used internally when looking up containers, like <VirtualHost> sections. It's after having written it that I realized it could be exposed on the Perl side. Figuring out a way to return a Tie::IxHash ref would certainly be the best solution IMHO. > __________________________________________________________________ > Stas Bekman JAm_pH ------> Just Another mod_perl Hacker > http://stason.org/ mod_perl Guide ---> http://perl.apache.org > mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com > http://modperlbook.org http://apache.org http://ticketmaster.com > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
signature.asc
Description: This is a digitally signed message part
