Regarding the xs and the test, you still had quite a few indentation problems, plus too wide lines (keep under 74 or so), but I've fixed those and committed.
Hargh ! I am still trying to figure out a way to automatically indent my stuff, but I am failing miserably... Can't get indent to produce mod_perl perfect code...
Well, I use cperl-mode in xemacs with a few tweaks it works great for me.
Good work, gozer! Now figure out how to get the hash preserve the keys order ;)
I'd put that as a TODO item and in the meantime I'll look if I can just plug Tie::IxHash in there instead of a regular hash.
I remember Doug was against creating any dependancies on the external modules.
Sure, but we can have both representations. Or, you can use APR::Table records as values, which if i remember correctly preserve the order. Though I don't think this will work with nesting, unless some magic is applied, because the keys have to be strings.May be it's better to s/as_hash/as_list/, it's easy to coerce a list into a hash.
Hmm... Not sure it would be any better. Really, as_hash is used internally when looking up containers, like <VirtualHost> sections. It's after having written it that I realized it could be exposed on the Perl side.
it certainly can be an optional thing, or at least something for now and fixed later to have a native solution.Figuring out a way to return a Tie::IxHash ref would certainly be the best solution IMHO.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
