On Fri, 14 Mar 2003, Stas Bekman wrote:
> Randy Kobes wrote:
> > Just for completeness, attached is a diff against the
> > src/modules/perl mod_perl 1.0 cvs directory which gets rid of
> > (all but one) warning on Win32.
>
> see below:
>
Thanks, Stas!
> > Index: src/modules/perl/Apache.xs
> > + SvGROW(buffer, (STRLEN) bufsiz+1);
>
> should we instead change the declaration of bufsiz to
>
> STRLEN bufsize;
That worked out - I had to also add
STRLEN T_IV
to Apache/typemap.
> > Index: src/modules/perl/Constants.xs
> > + my_newCONSTSUB(stash, name, newSViv((I32) val));
>
> +1
done ...
> > Index: src/modules/perl/mod_perl.c
> > +
> > +#ifndef WIN32
> > perl_request_sigsave **sigs;
> > int i;
> > +#endif
>
> +1
done ...
> > Index: src/modules/perl/mod_perl.h
> > +int perl_load_startup_script(server_rec *s, pool *p, char *script,
> > unsigned char my_warn);
> I think that should be: s/I32/U8/
That worked out - thanks.
> > Index: src/modules/perl/perl_config.c
> > +#ifndef WIN32
> > int i;
> > +#endif
>
> +1
done ...
> > + unsigned char oldwarn = dowarn; /*XXX, hmm*/
> U8?
yup ...
> > Index: src/modules/perl/perl_util.c
> > + unsigned char old_warn = dowarn;
> > +int perl_load_startup_script(server_rec *s, pool *p, char *script,
> > unsigned char my_warn)
> > + unsigned char old_warn = dowarn;
>
> U8, all above.
right again ...
> > + if(i >= (int) SvCUR(errsv))
> > + if((int) SvCUR(errsv) == http_code)
>
> s/int i=0/STRLEN i=0/?
that works, and the same for http_code.
> I think it's cleaner to use the right type in first place, instead of doing
> casting, if possible.
Good point ... thanks again ...
--
best regards,
randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
