Randy Kobes wrote:
On Fri, 14 Mar 2003, Stas Bekman wrote:


Randy Kobes wrote:


Index: src/modules/perl/Apache.xs
+        SvGROW(buffer, (STRLEN) bufsiz+1);

should we instead change the declaration of bufsiz to


STRLEN bufsize;


That worked out - I had to also add STRLEN T_IV
to Apache/typemap.

But I think it should be: T_UV At least it's T_UV in the core 5.8.0's typemap (it wasn't there before)


I had used the one under perl-5.8.0/ext/B/typemap, but it is
defined as T_UV in, eg, lib/ExtUtils/typemap. For me, on Win32,
with perl-5.6.1, either one has all tests passing.

since its a STRLEN and it can't be negative, I think the right type is UV. Not that it much matters, but since we perfect things, let's have it perfect ;)


I'll send a patch for B/typemap to p5p.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to