I'm starting to work on this again (for the complete thread, in case it's not fresh in your mind, see http://marc.theaimsgroup.com/?t=105431745200001&r=1&w=2)
anyway, I'm working through an implementation that uses modperl_hook_t. as I'm going through it, the patch is getting bigger and bigger, as a single modperl_hook_t can (and probably should) hold all the information we need to know about a hook - MP_HANDLER_TYPE_*, description, run_mode, and so on.
the issue for me right now is the concept of idx - that is, using a matrix to map handlers to per-server or per-dir run-types. for instance, MP_TRANS_HANDLER and MP_AUTHEN_HANDLER are both 1, but the former has a MP_HANDLER_TYPE_PER_SERVER. to me, this is excessive, and I'd rather see all the handlers with unique identifiers. if we did this, then a modperl_hook_t could hold all the info it needs - modperl_handler_lookup could do a lookup by name for get/set_handlers, and (a new) modperl_handler_lookup_by_idx could do a lookup by index. as it stands now, to lookup by idx requires the idx and type, which leaves only the description around (and all those modperl_handler_desc_* functions).
so, are there any objections to just using an enum for all the handlers and going from there? am I missing something that somehow makes thix matrix preferable?
--Geoff
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
